Bump gvisor.dev/gvisor to 20240729.0 #379
Conversation
Signed-off-by: Shengjing Zhu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhsj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
gvisor.dev/gvisor are always tricky when they come with an update to a newer major go version. This PR changes the minimum go version from 1.21 to 1.22, which at the moment would be problematic for me, as one of the OSes I need to build this code on only has go 1.21 :-/ The fedora 39 build failures for example are caused by this.
A new release of gvisor-tap-vsock will be needed soon because of #385 , we can't merge this PR before this.
I see at least 2 ways forward here:
- we update gvisor to the latest version supporting go 1.21. I did that in https://github.com/cfergeau/gvisor-tap-vsock/tree/bump-gvisor-9e5a99. Then we switch to the latest version requiring go 1.22 a bit later (let's say in a few weeks)
- we hold this PR for a bit, and switch to the latest version requiring go 1.22 in a few weeks
Any thoughts or that?
| } | ||
|
|
||
| func (e *LinkEndpoint) Wait() {} | ||
| func (e *LinkEndpoint) Close() {} | ||
| func (e *LinkEndpoint) SetOnCloseAction(action func()) {} |
There was a problem hiding this comment.
This should be SetOnCloseAction(_ func()) to avoid a lint failure.
Looks like we went with this option :) I've rebased this, and updated it to the latest gvisor tag in https://github.com/cfergeau/gvisor-tap-vsock/tree/gvisor-update |
I've created #397 |
No description provided.